Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SHS-5561: Implementation: Responsive styles for h4 and h5 #1497

Merged
merged 2 commits into from
Apr 5, 2024
Merged

SHS-5561: Implementation: Responsive styles for h4 and h5 #1497

merged 2 commits into from
Apr 5, 2024

Conversation

cienvaras
Copy link
Collaborator

READY FOR REVIEW

Summary

  • Update h4/h5/h6 styles to make them responsive
  • Update card title styles to make them independent of hb-heading-5 mixin

Need Review By (Date)

04/05

Urgency

medium

Steps to Test

  1. Repeat the following steps in Colorful and Traditional:
    a. Create a Flexible page. In the text area, add some text containing h4, h5 and h6 headings. Save the page and confirm that the sizes and line heights match the ones specified un the Text Styles doc.
    b. Edit the Flexible page and add a vertical card. Make sure that it's not inside a collection or any grid. Make sure that the card title sizes and line heights match the ones in the table below.
    c. Visit https://hs-colorful.suhumsci.loc/collections-cards-continued and https://hs-traditional.suhumsci.loc/components/collections-cards-continued. Confirm that the card title sizes and line heights match the ones in the table below.

Card title (outside collection/grid)

Colorful

Item Base sm (576px) md (768px)
Font Size 18px 24px 27px
Line Height 124% 124% 119%

Traditional

Item Base sm (576px) md (768px)
Font Size 20px 24px 27px
Line Height 126% 124% 119%

Card title (inside collection/grid)

Colorful

Item Base lg (992px)
Font Size 18px 20px
Line Height 124% 124%

Traditional

Item Base sm (576px)
Font Size 20px 22px
Line Height 126% 126%

PR Checklist

@cienvaras cienvaras requested a review from mariannuar April 4, 2024 21:56
@cienvaras cienvaras self-assigned this Apr 4, 2024
@cienvaras cienvaras marked this pull request as ready for review April 4, 2024 22:51
mariannuar
mariannuar approved these changes Apr 5, 2024
View reviewed changes
Copy link
Collaborator

@mariannuar mariannuar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cienvaras Looks and works as expected! :shipit:

@cienvaras cienvaras merged commit 3a5e735 into fk-stnfd-sprint-47 Apr 5, 2024
12 of 15 checks passed
@cienvaras cienvaras deleted the shs-5561--responsive-styles-h4-h5-h6 branch April 5, 2024 17:12
joegl pushed a commit that referenced this pull request Apr 11, 2024
@cienvaras
Four Kitchens Release - Sprint 47 (#1495)
f673c25 
* SHS-5567: Implementation: Hide "Show as Expanded" toggle in menu settings on node form (#1490)
* SHS-5515: Implementation: Adjustments to vertical cards (#1487)
* SHS-5561: Implementation: Responsive styles for h4 and h5 (#1497)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariannuar mariannuar mariannuar approved these changes

Assignees

@cienvaras cienvaras

Labels
Passes code review Passes functional review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cienvaras @mariannuar